-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-20760: Add wait argument to member onboarding in GetRegistrationsTest #6278
Conversation
Jenkins build for PR 6278 build 9 Build Successful: |
@@ -86,6 +87,7 @@ class GetRegistrationsTest { | |||
user, | |||
password, | |||
INSECURE, | |||
WAIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add this to the registration on line 54?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must have missed that one, thanks.
@@ -180,8 +179,6 @@ abstract class BaseOnboard : Runnable, RestCommand() { | |||
|
|||
if (hasKeys) return | |||
|
|||
println("Creating TLS key.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you taking these out?
They were put in to help spot where the journey breaks down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I must have misunderstood your comment on the original ticket. Could you point me to where the sleep is that you mentioned? I can't see any sleeps in the commit that I reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sleep was swapped for polling an alternate endpoint: #6247 (comment)
This is the code it was replaced with: 40164d5
I expect the println statements to remain, only the above executeWithRetry block to be taken out.
@@ -206,6 +197,9 @@ class OnboardMember : Runnable, BaseOnboard() { | |||
|
|||
setupNetwork() | |||
|
|||
println("Provided registration context: ") | |||
println(memberRegistrationRequest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take these out
7becafe
to
9d6da89
Compare
9d6da89
to
2816365
Compare
|
When onboarding members in GetRegistrationsTest, we have not been passing the
--wait
argument which has caused errors due to registration not being completed before the member is used. This PR reverts the temporary fix to the tests and adds the argument to prevent the issue from re-occurring.I have also done a few test runs of the plugins smoke tests against this PR and the issue hasn't occurred in any of them.