CORE-20760: Add wait argument to member onboarding in GetRegistrationsTest #6278
Conversation
|
Jenkins build for PR 6278 build 9 Build Successful: |
| @@ -86,6 +87,7 @@ class GetRegistrationsTest { | |||
| user, | |||
| password, | |||
| INSECURE, | |||
| WAIT | |||
There was a problem hiding this comment.
Should we also add this to the registration on line 54?
There was a problem hiding this comment.
Must have missed that one, thanks.
| @@ -180,8 +179,6 @@ abstract class BaseOnboard : Runnable, RestCommand() { | |||
|
|
|||
| if (hasKeys) return | |||
|
|
|||
| println("Creating TLS key.") | |||
There was a problem hiding this comment.
Why are you taking these out?
They were put in to help spot where the journey breaks down.
There was a problem hiding this comment.
Apologies, I must have misunderstood your comment on the original ticket. Could you point me to where the sleep is that you mentioned? I can't see any sleeps in the commit that I reverted.
There was a problem hiding this comment.
The sleep was swapped for polling an alternate endpoint: #6247 (comment)
This is the code it was replaced with: 40164d5
I expect the println statements to remain, only the above executeWithRetry block to be taken out.
| @@ -206,6 +197,9 @@ class OnboardMember : Runnable, BaseOnboard() { | |||
|
|
|||
| setupNetwork() | |||
|
|
|||
| println("Provided registration context: ") | |||
| println(memberRegistrationRequest) | |||
malachyb
force-pushed
the
Malachy/CORE-20760
branch
from
7becafe
to
9d6da89
Compare
malachyb
force-pushed
the
Malachy/CORE-20760
branch
from
9d6da89
to
2816365
Compare
|
When onboarding members in GetRegistrationsTest, we have not been passing the
--waitargument which has caused errors due to registration not being completed before the member is used. This PR reverts the temporary fix to the tests and adds the argument to prevent the issue from re-occurring.I have also done a few test runs of the plugins smoke tests against this PR and the issue hasn't occurred in any of them.