Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid check of IOUState on full settlement flow #22

Open
ooharawork opened this issue Aug 15, 2018 · 0 comments
Open

Invalid check of IOUState on full settlement flow #22

ooharawork opened this issue Aug 15, 2018 · 0 comments

Comments

@ooharawork
Copy link

ooharawork commented Aug 15, 2018

val signedTransactionFlow = object : SignTransactionFlow(flowSession) {
override fun checkTransaction(stx: SignedTransaction) = requireThat {
val outputStates = stx.tx.outputs.map { it.data::class.java.name }.toList()
"There must be an IOU transaction." using (outputStates.contains(IOUState::class.java.name))

In the case of full settlement, the transaction must not contain an IOUState in output, therefore the code above produces an error.

The check should be removed as in corda-training-solutions, or modified such that the check is made only when in a partial settlement.

BTW I don't have much expertise on Corda so not sure but, I doubt that that check is really required here, because we have already similar checks in IOUContract.

sbir3japan-admin pushed a commit to sbir3japan/corda-dev-traning-sbir3japan that referenced this issue Dec 17, 2020
Remove CordaPluginRegistry and give whitelisting example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant