CORDA-1915 node rejects CorDapps signed by our dev keys in prod mode #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonsztuka
force-pushed
the
features/CORDA-1915-prod-mode-reject-cordapss-sign-by-our-dev-key
branch
from
59ff62d
to
45166df
Compare
…development keys when running in production mode - this is to prevent Cordapps signed by our dev key (will be by default) not to run in production
…development keys when running in production mode - unit tests
szymonsztuka
force-pushed
the
features/CORDA-1915-prod-mode-reject-cordapss-sign-by-our-dev-key
branch
from
45166df
to
d75b509
Compare
|
Other than my query above, this all LGTM. |
…er merge with master.
r3domfox
approved these changes
Oct 24, 2018
| @@ -507,10 +508,12 @@ abstract class AbstractNode<S>(val configuration: NodeConfiguration, | |||
| // CorDapp will be generated. | |||
| generatedCordapps += VirtualCordapp.generateSimpleNotaryCordapp(versionInfo) | |||
| } | |||
| val blacklistedCerts = if (configuration.devMode) DEV_CERTIFICATES else emptyList() | |||
There was a problem hiding this comment.
If I understand correctly, we want to blacklist the DEV_CERTIFICATES if we're not in dev mode? In which case, shouldn't this be if (!configuration.devMode)?
szymonsztuka
deleted the
features/CORDA-1915-prod-mode-reject-cordapss-sign-by-our-dev-key
branch
roastario
pushed a commit
to roastario/corda
that referenced
this pull request
Nov 8, 2018
…orda#4041) Related to CORDA-1915 Signing CorDapp JARs - Corda node rejects CorDapps signed by our development keys when running in production mode. This prevents Cordapps signed by our dev key (by default) running in production (node devMode=false).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Signing CorDapp JARs - Corda node rejects CorDapps signed by our development keys when running in production mode - this is to prevent Cordapps signed by our dev key (will be by default) running in production (node devMode=false).
Full context of this PR described in https://r3-cev.atlassian.net/browse/CORDA-1915