Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle cache friendly Junit test fix. #4044

Merged
merged 1 commit into from Oct 8, 2018

Conversation

josecoll
Copy link

@josecoll josecoll commented Oct 8, 2018

Gradle caches artefacts by task execution signature.
A test module of core-deterministic depends on the generated artefacts of an associated data module. Once the data module task is cached its generated outputs are no longer available to the test module (and hence 2 unit tests fail).
This fix forces re-execution of the data module prior to running the previously failing test module VerifyTransactionTest

@josecoll josecoll requested a review from chrisr3 October 8, 2018 11:24
Copy link
Contributor

@chrisr3 chrisr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, go on then! 😒

@josecoll josecoll merged commit d987f18 into master Oct 8, 2018
@shamsasari shamsasari deleted the colljos-fix-gradle-cache-failing-test branch October 27, 2018 10:39
roastario pushed a commit to roastario/corda that referenced this pull request Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants