Merge westonganger #175
Merged
Merge westonganger #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove extra android folders, update plugin id
so npmjs.com will display a link to github
* Continous auto focus mode for android camera Solution adapted from #53 (comment) * Update README.md * Update README.md * Improve compatibility with other plugins. Insert UIView at a relative tree location to cordova's UIWebView rather than at an absolute location. * Add config options * Add config options * Use generated id for view to prevent conflicts. * Use 0/0 as resolution when none is specified. * Use height in android preview size computation.
The original base64-encoded bitmap tended to be very large for hi-res cameras; this caused long loading times loading the base64 string into an image (data: uri). To mitigate the output bitmap is now scaled to the original view size, and the JPEG compression is down to 85 from 95. Additionally, I removed the newlines from the base64 output.
Removes the carriage returns form base64 string
* Includes the base64 header into the picture base64 string * Updates setOnPictureTakenHandler documentation * removes base64 part of the documentation as it is outdated
* Update android code to correctly crop and scale the image * Fix argument types * Fix missing files
Per #8 of this doc https://developer.android.com/reference/android/hardware/Camera.html, after a picture was taken the preview must be restarted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.