Record Video Functionality (Android Only) #587
Conversation
|
@vipulsharma144 this is looking pretty good. Can you resolve the conflicts? |
|
@westonganger Conflicts are resolved. |
|
This is a pretty large change. Do you have any additional comments before I start review? |
|
@westonganger not much to comment on this .Please help in the review . |
| @@ -1,4 +1,5 @@ | |||
| # Cordova Plugin Camera Preview | |||
There was a problem hiding this comment.
Please remove all formatting that was applied to the README. Please include only add your additions.
| | FIXED | string | fixed | | | ||
| | AUTO | string | auto | | | ||
| | CONTINUOUS | string | continuous | IOS Only | | ||
| | Name | Type | Default | Note | |
There was a problem hiding this comment.
Please remove the formatting on the tables. This new formatting makes it harder to edit the table.
| console.log(characteristics); | ||
| }); | ||
| ``` | ||
|
|
||
| ### backgroundVideoStart(cb, [errorCallback]) | ||
|
|
||
| _Currently this feature is for Android only._ |
There was a problem hiding this comment.
Is this actually android only? I am pretty sure the iOS is implemented too.
|
|
||
| ### backgroundVideoStop(cb, [errorCallback]) | ||
|
|
||
| _Currently this feature is for Android only._ |
There was a problem hiding this comment.
Is this actually android only? I am pretty sure the iOS is implemented too.
There was a problem hiding this comment.
No it wasnt actually implemented. PR wanted for iOS support.
|
@vipulsharma144 please follow up with my comments so we can keep the ball rolling on this PR. |
|
@westonganger whoa 🤩 !! Thanks for the detailed review I am on it . Will update asap. |
|
Alright this looks good enough now. Thanks @vipulsharma144 for your hard work on this PR. |
westonganger
changed the title
Record Video
Save Video To cache
Stop Video Record and returns recorded video path
Android Only