Text not drawing on OS X 10.11 (El Capitan)

[corysullivan]

I just installed the latest Beta for 10.11 and noticed that the text for all the core-plot graphs aren't appearing . Initially I though this may be related to issue #167 , but my app (including dependencies) do not use the stylemask

NSFullSizeContentViewWindowMask

Any thoughts on what else could be causing this? Has anyone else tested 10.11? I'm currently using coreplot 1.6

Thanks

[eskroch]

I don't have access to 10.11 for testing yet. Any troubleshooting you can do would be a big help in fixing this.

[corysullivan]

Sure I will see what I can come up with.

[kepowell]

I am having the same problem with text on El Capitan. I haven't had a chance to debug the code but an observation that might give some ideas. When running the CPTTestApp the vertical zoom causes the tick numbers to appear and the horizontal zoom out causes the numbers that were outside the previous view to appear. If you then move the graph around any numbers that get moved outside the view disappear until re-zooming. It seems to me that this means that once a text item is masked out for any reason that it is not drawn on refreshes.

[tvlc]

Same issues with 10.11 El Capitan GM Candidate. Any progress and fix planned for 1.6 release?

[Dirk-]

I see this too. The version of my app which uses Core Plot 1.6 does not display any text on 10.11 GM (runs fine on 10.10.5), the former version which uses Core Plot 1.5.1 does display the text. I only switched from 1.5.1 to 1.6 the day before yesterday and did not change my plotting code.

Well, I am not exactly using 1.6, I use the master repository with these 24 commits since 1.6.

[eskroch]

@tvlc Not for version 1.x, but this issue is the last showstopper holding up release 2.0.

[vrbaski]

The following change works for me:
I set the current graphics context (CPTTextStylePlatformSpecific.m) to a context passed to the drawInRect.
I had to clear it at the end or I was getting exceptions later. I'm not sure if that is a good fix, but it works for me.

-(void)drawInRect:(CGRect)rect withTextStyle:(CPTTextStyle *)style inContext:(CGContextRef)context
{
if ( style.color == nil ) {
return;
}

CGColorRef textColor = style.color.cgColor;

BOOL currenContextIsNIL = NO;
NSGraphicsContext *currentContext = [NSGraphicsContext currentContext];
if(currentContext ==nil)
{
    [NSGraphicsContext setCurrentContext:[NSGraphicsContext graphicsContextWithGraphicsPort:context flipped:NO]];
    currenContextIsNIL = YES;
}

CGContextSetStrokeColorWithColor(context, textColor);
CGContextSetFillColorWithColor(context, textColor);

CPTPushCGContext(context);

NSFont *theFont    = nil;
NSString *fontName = style.fontName;

if ( fontName ) {
    theFont = [NSFont fontWithName:fontName size:style.fontSize];
}

if ( theFont ) {
    NSColor *foregroundColor                = style.color.nsColor;
    NSMutableParagraphStyle *paragraphStyle = [[NSMutableParagraphStyle alloc] init];
    paragraphStyle.alignment     = (NSTextAlignment)style.textAlignment;
    paragraphStyle.lineBreakMode = style.lineBreakMode;

    NSDictionary *attributes = @{
        NSFontAttributeName: theFont,
        NSForegroundColorAttributeName: foregroundColor,
        NSParagraphStyleAttributeName: paragraphStyle
    };
    [self drawWithRect:NSRectFromCGRect(rect)
               options:NSStringDrawingUsesLineFragmentOrigin | NSStringDrawingUsesFontLeading | NSStringDrawingTruncatesLastVisibleLine
            attributes:attributes];
}
CPTPopCGContext();

if(currenContextIsNIL)
{
    [NSGraphicsContext setCurrentContext:nil];
}

}

[canpoyrazoglu]

Having the same here, I think I should go back to old version until this is fixed.

[Dirk-]

@vrbaski: I tried your code suggestion and it partly worked: Without your code change, I get no text at all, with your code change I get text in the legend, graph title, axis title and annotations, but not for axis labels! Strange...

[Dirk-]

I added the same code additions to drawRect of the NSAttributedString category in CPTPlatformSpecificCategories.m and now I get text everywhere I want:

-(void)drawInRect:(CGRect)rect inContext:(CGContextRef)context
{
    // -------- Addition for OS X 10.11
    BOOL currentContextIsNIL = NO;
    if([NSGraphicsContext currentContext] == nil)
    {
        [NSGraphicsContext setCurrentContext:[NSGraphicsContext graphicsContextWithGraphicsPort:context flipped:NO]];
        currentContextIsNIL = YES;
    }
    // -------- End Addition

    CPTPushCGContext(context);

    [self drawWithRect:NSRectFromCGRect(rect)
               options:NSStringDrawingUsesLineFragmentOrigin | NSStringDrawingUsesFontLeading | NSStringDrawingTruncatesLastVisibleLine];

    CPTPopCGContext();

    // -------- Addition for OS X 10.11
    if(currentContextIsNIL)
    {
        [NSGraphicsContext setCurrentContext:nil];
    }
    // -------- End Addition
}

And it still works in OS X 10.10. Great! Thanks, @vrbaski and, of course, thanks @eskroch et al. for Core Plot!

[mike-lischke]

I wonder why there is this need to check for the current context first. Does it not work on older OS versions otherwise? There is a context passed in and that should be used for drawing, no? In all cases. And resetting the current context always, also seems reasonable. Other drawing code will exactly do the same like here, namely set a proper drawing context first. Maybe I'm missing something here?

[eskroch]

The fix needs to be in the CPTPushCGContext() and CPTPopCGContext() functions. This keeps the context handling code in one place making it easier to maintain in the future.

[eskroch]

This should be fixed now on both the master and release-2.0 branches. Please test and let me know if it's working. If so, I'll move forward with the 2.0 release.

[pascalfribi]

Hi,

I have pulled the Xcode 7 branch and tested it on my application. This seems to work fine again! Thanks for this great library! Do you plan to make a small Apple Watch API? :-)

[eskroch]

Good to hear. I'm thinking about adding watchOS and tvOS frameworks to release 2.1. :-)