net.c: properly check result of vsnprintf() in 'send_remote_command()' #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An excessively long remote command may get truncated by 'vsnprintf()' call in L87 which may go unnoticed by the incorrect check in L89 resulting in two bytes written beyond 'char cmd[4096]' array with 'strcat()' in L95 that assumes enough space was left in the buffer to append "\r\n" Includes <setjmp.h> and <signal.h> are not used in this file - removed; missing '#include <stdarg.h>' (needed for va_start/va_end()) and '#include <stdio.h>' (needed for vsnprintf()) added.
|
Please only change the conditional in this PR, i.e. one line change.
… On May 5, 2024, at 18:01, Alex Vasylenko ***@***.***> wrote:
An excessively long remote command may get truncated by 'vsnprintf()' call in L87 which may go unnoticed by the incorrect check in L89 resulting in two bytes written beyond 'char cmd[4096]' array with 'strcat()' in L95 that assumes enough space was left in the buffer to append "\r\n"
Includes <setjmp.h> and <signal.h> are not used in this file - removed; missing '#include <stdarg.h>' (needed for va_start/va_end()) and '#include <stdio.h>' (needed for vsnprintf()) added.
You can view, comment on, or merge this pull request online at:
#134
Commit Summary
• dcc8767 net.c: properly check result of vsnprintf() in 'send_remote_command()'
File Changes
(1 file)
• M net.c (6)
Patch Links:
• https://github.com/corecode/dma/pull/134.patch
• https://github.com/corecode/dma/pull/134.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An excessively long remote command may get truncated by 'vsnprintf()' call in L87 which may go unnoticed by the incorrect check in L89 resulting in two bytes written beyond 'char cmd[4096]' array with 'strcat()' in L95 that assumes enough space was left in the buffer to append "\r\n"