Auto build and deploy via Netlify #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stp-ip
force-pushed
the
netlify
branch
4 times, most recently
from
c6324c0
to
36775be
Compare
|
is still also needed? (I'm just merging) |
|
Will rebase and then can merge in. This is the netlify part. So auto syncing should already work, but wanted to separate the syncing from the netlify part. |
This adds all remaining configuration to auto build and deploy via Netlify. In addition to deploying master it also enables PR review deploys. Signed-off-by: Michael Grosser <development@stp-ip.net>
|
[ Quoting <notifications@github.com> in "Re: [coredns/coredns.io] Auto buil..." ]
Will rebase and then can merge in. This is the netlify part. So auto syncing should already work, but wanted to separate the syncing from the netlify part.
check.
And tls certs and the like is done by netifly I presume? Currenltly is doesn't.
beta.coredns.io point to netifly btw
|
|
Pushed and ready to merge. Yes TLS is done via let's encrypt once DNS is switched. Will enable TLS for beta.coredns.io and check again on the netlify side. |
|
TLS provisioned for beta.coredns.io \o/ |
|
[ Quoting <notifications@github.com> in "Re: [coredns/coredns.io] Auto buil..." ]
TLS provisioned for beta.coredns.io \o/
woot
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all remaining configuration to auto build and deploy
via Netlify. In addition to deploying master it also enables PR
review deploys.
It builds up on #178, but happy to rebase after #178 is merged.