Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor of proxy parsing to make upstreams re-usable #1426

Merged
merged 1 commit into from Jan 27, 2018

Conversation

johnbelamaric
Copy link
Member

1. What does this pull request do?

Refactors upstream parsing so we can re-use it in other plugins than proxy. For example, fallback. Doing this in a separate PR means fallback can be external if we want.

It creates a function NewStaticUpstream that performs the parsing starting at the FROM.

2. Which issues (if any) are related?

#1382

3. Which documentation changes (if any) need to be made?

None.

@codecov-io
Copy link

Codecov Report

Merging #1426 into master will increase coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1426      +/-   ##
=========================================
+ Coverage   52.07%   52.1%   +0.02%     
=========================================
  Files         173     173              
  Lines        8465    8470       +5     
=========================================
+ Hits         4408    4413       +5     
  Misses       3718    3718              
  Partials      339     339
Impacted Files Coverage Δ
plugin/proxy/upstream.go 83.2% <94.44%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfb998...f24a67e. Read the comment docs.

@miekg
Copy link
Member

miekg commented Jan 27, 2018

I'm fine with this, but I'm not sure if you want proliferate proxy and maybe instead focus on forward
Also see #1443

@johnbelamaric
Copy link
Member Author

Ok. Well, I will merge anyway, we can see about trying it with forward.

@johnbelamaric johnbelamaric merged commit d27be86 into coredns:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants