Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate plugin/proxy #1443

Closed
miekg opened this issue Jan 26, 2018 · 11 comments

Comments

@miekg
Copy link
Member

commented Jan 26, 2018

I want to deprecate proxy in favor of forward.

Why:
We have had a long discussion on Slack about an outage that is attributed to the proxy code (spec. the healthchecking (HC)). This took 2 engineers quite a while to reason about the current code; it is complex. I think it is gotten too complex.

  • The HC pings an HTTP endpoint, which no relation the upstream's ability to respond to DNS
  • The policy frameworks adds flexibility, but brings a lot of code with it. Most people should be content with just randomizing an upstream

forward uses inband HC (by default), and just traverses a list, so no Select() what proxy currently does. And the code in forward is simpler. It also caches udp and tcp sockets, so it is faster.

Why not:

  • proxy is more battle hardened than forward
  • forward does not support grpc (can be added?) not https_google

Proposal:

  • Add forward, convert all in-plugin callers to forward.Lookup instead of proxy.Lookup
  • Deprecate proxy, but leave it for grpc and https_google (in case of the later HC is also broken, oh the irony)

@miekg miekg added the plugin/proxy label Jan 26, 2018

@fturib

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2018

For Infoblox use case, I need a proxy/forward with:

  • grpc (and dns)
  • policy (I plan to add another one named "always_first" that always tries by the same order)
  • aggregate health of the proxy/forward to global coredns health status (I plan to implement the Healther interface on proxy). NOTE: I do not need the health check on upstream servers
@miekg

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2018

yeah, forward must/should support grpc. and health.Healther is sensible for all plugins.

Not 100% sold on the need to specify client side policy.

@grobie

This comment has been minimized.

Copy link
Collaborator

commented Jan 26, 2018

👍 from our side, but we don't need grpc, policies other than random or HTTP checks. My opinion on "battle hardened" differs as well ;-)

@miekg

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2018

"seen more production use" might be a better description.

@miekg

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2018

Also: if you query proxy and the upstream of proxy timeout, this is attributed to the proxy, forward avoids this mistake.

@summerwind

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

We have been used proxy plugin to allow to use with external service via gRPC in production. But It seems that proxy plugin is already deptecated (#2651).

This causes the block of update of CoreDNS in our environment. Are there specific plans to support gRPC in the forward plugin?

@miekg

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

@stefanmb

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@miekg It's worth pointing out that forward does not support dnstap logging of forwarded queries/responses, so deprecating proxy effectively cripples the usefulness of the dnstap plugin if we don't add the functionality to forward.

@miekg

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@stefanmb

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Found it #1448 - thank you!

@miekg

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

closing here, as its' gone. Cleaning up the last bit and then really make it external.

@miekg miekg closed this Mar 13, 2019

kquinsland added a commit to kquinsland/skyhole that referenced this issue Sep 13, 2019
Update Corefile
Correct the `Corefile` use of `proxy` with `forward`. Proxy directive was deprecated here:

coredns/coredns#1443
@agamus agamus referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.