presubmit: check for uppercase #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another thing we can test automatically, we sorta settled on using an uppercase letter in in t.Log and t.Fatal calls. Let's just check for this.
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
==========================================
- Coverage 54.51% 54.49% -0.03%
==========================================
Files 192 192
Lines 9489 9489
==========================================
- Hits 5173 5171 -2
+ Misses 3931 3930 -1
- Partials 385 388 +3
Continue to review full report at Codecov.
|
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
Another thing we can test automatically, we sorta settled on using an uppercase letter in in t.Log and t.Fatal calls. Let's just check for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another thing we can test automatically, we sorta settled on using an
uppercase letter in in t.Log and t.Fatal calls.
Let's just check for this.
1. What does this pull request do?
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?