Remove version pinning of thrift, ugoriji/go, and etcd #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For incompatibility reasons at one point, we were forced to pining the version of thrift, ugoriji/go, and etcd to very specific versions (some are not versioned commits) to get around the build issues. It looks like those incompatibility issues are gone so we could remove the pinning of thrift, ugoriji/go, and etcd. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked varyoo (via If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository. The bot understands the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #2457 +/- ##
=========================================
+ Coverage 56.37% 56.4% +0.02%
=========================================
Files 208 208
Lines 10490 10490
=========================================
+ Hits 5914 5917 +3
+ Misses 4124 4122 -2
+ Partials 452 451 -1
Continue to review full report at Codecov.
|
|
/lgtm |
![corbot[bot]](https://avatars.githubusercontent.com/u/21110084?s=60&v=4){kind=small}
kingforaday
added a commit
to kingforaday/coredns
that referenced
this pull request
Jan 12, 2019
Remove version pinning of thrift, ugoriji/go, and etcd (coredns#2457)
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
* Remove version pinning of thrift, ugoriji/go, and etcd For incompatibility reasons at one point, we were forced to pining the version of thrift, ugoriji/go, and etcd to very specific versions (some are not versioned commits) to get around the build issues. It looks like those incompatibility issues are gone so we could remove the pinning of thrift, ugoriji/go, and etcd. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update Gopkg.lock Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update vendor library Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
dna2github
pushed a commit
to dna2fork/coredns
that referenced
this pull request
Jul 19, 2019
* Remove version pinning of thrift, ugoriji/go, and etcd For incompatibility reasons at one point, we were forced to pining the version of thrift, ugoriji/go, and etcd to very specific versions (some are not versioned commits) to get around the build issues. It looks like those incompatibility issues are gone so we could remove the pinning of thrift, ugoriji/go, and etcd. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update Gopkg.lock Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update vendor library Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
For incompatibility reasons at one point, we were forced
to pining the version of thrift, ugoriji/go, and etcd
to very specific versions (some are not versioned commits)
to get around the build issues.
It looks like those incompatibility issues are gone so
we could remove the pinning of thrift, ugoriji/go, and etcd.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
Signed-off-by: Yong Tang yong.tang.github@outlook.com