Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/log: remove timestamp #3218

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@miekg
Copy link
Member

commented Aug 28, 2019

journald timestamps, kubernetes timestamps, syslog timestamps. It seems
silly to add our own timestamps to the logging output as these external
ones also do it. Only when just running coredns this might be weird.

Remove the timestamping from pkg/log.

Remove test that tested for this.

Fixes: #3211

pkg/log: remove timestamp
journald timestamps, kubernetes timestamps, syslog timestamps. It seems
silly to add our own timestamps to the logging output as these external
ones *also* do it. Only when just running coredns this might be weird.

Remove the timestamping from pkg/log.

Remove test that tested for this.

Fixes: #3211

Signed-off-by: Miek Gieben <miek@miek.nl>

@corbot corbot bot requested a review from stp-ip Aug 28, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 28, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked stp-ip (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

Merging #3218 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
- Coverage   55.78%   55.78%   -0.01%     
==========================================
  Files         206      206              
  Lines       10418    10417       -1     
==========================================
- Hits         5812     5811       -1     
  Misses       4186     4186              
  Partials      420      420
Impacted Files Coverage Δ
plugin/pkg/log/log.go 73.33% <100%> (-0.87%) ⬇️
plugin/route53/route53.go 84.5% <0%> (-2.12%) ⬇️
plugin/clouddns/clouddns.go 85.45% <0%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df62359...5ef5959. Read the comment docs.

@chrisohaver chrisohaver merged commit 6fdf130 into master Aug 28, 2019

4 checks passed

ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.78% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the no-log-timestamp branch Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.