plugin/auto: warn when auto is unable to read elements of the directory tree #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
|
I'm hoping there does not exist a valid use case where this warning would be too spammy. |
Codecov Report
@@ Coverage Diff @@
## master #6333 +/- ##
==========================================
+ Coverage 55.70% 58.49% +2.79%
==========================================
Files 224 252 +28
Lines 10016 16540 +6524
==========================================
+ Hits 5579 9675 +4096
- Misses 3978 6277 +2299
- Partials 459 588 +129
... and 170 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Log a warning when auto is unable to read elements of its directory tree. Displaying a warning message will help with troubleshooting directory/file permission issues. Currently, no message is logged when the configured directory, or elements within are not listable/readable.
2. Which issues (if any) are related?
closes #6318
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?