Generate zplugin.go correctly with third-party plugins #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcs278
requested review from
bradbeam,
chrisohaver,
dilyevsky,
jameshartig,
greenpau,
Isolus,
johnbelamaric,
miekg,
pmoroney,
rajansandeep,
stp-ip,
SuperQ,
yongtang and
Tantalor93
as code owners
gcs278
force-pushed
the
zplugin-third-party-plugin-generation
branch
from
89c1116
to
d291494
Compare
Previously, the generation of zplugin.go would not separate third-party external plugins from CoreDNS plugins in the go import block. This leads to the TestImportOrdering unit test failing, as it requires that third-party imports paths to be in a separate import block. While this issue does not affect the main CoreDNS repo, it can cause unit test failures in forks of CoreDNS that include external third-party plugins. Signed-off-by: Grant Spence <gspence@redhat.com>
gcs278
force-pushed
the
zplugin-third-party-plugin-generation
branch
from
d291494
to
0c8e1fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6692 +/- ##
==========================================
+ Coverage 55.70% 59.19% +3.49%
==========================================
Files 224 252 +28
Lines 10016 13471 +3455
==========================================
+ Hits 5579 7974 +2395
- Misses 3978 4905 +927
- Partials 459 592 +133 ☔ View full report in Codecov by Sentry. |
|
@chrisohaver or whoever appropriate, could I get a quick review? Should be low-risk as it doesn't impact this CoreDNS repo, but allows for forks to pass unit tests if they are adding 3rd party plugins. |
gcs278
added a commit
to gcs278/coredns
that referenced
this pull request
May 29, 2024
Generate zplugin.go correctly with third-party plugins (coredns#6692) Previously, the generation of zplugin.go would not separate third-party external plugins from CoreDNS plugins in the go import block. This leads to the TestImportOrdering unit test failing, as it requires that third-party imports paths to be in a separate import block. While this issue does not affect the main CoreDNS repo, it can cause unit test failures in forks of CoreDNS that include external third-party plugins. Signed-off-by: Grant Spence <gspence@redhat.com>
gcs278
added a commit
to gcs278/coredns
that referenced
this pull request
Jun 10, 2024
Generate zplugin.go correctly with third-party plugins (coredns#6692) Previously, the generation of zplugin.go would not separate third-party external plugins from CoreDNS plugins in the go import block. This leads to the TestImportOrdering unit test failing, as it requires that third-party imports paths to be in a separate import block. While this issue does not affect the main CoreDNS repo, it can cause unit test failures in forks of CoreDNS that include external third-party plugins. Signed-off-by: Grant Spence <gspence@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/coredns
that referenced
this pull request
Jun 11, 2024
Generate zplugin.go correctly with third-party plugins (coredns#6692) Previously, the generation of zplugin.go would not separate third-party external plugins from CoreDNS plugins in the go import block. This leads to the TestImportOrdering unit test failing, as it requires that third-party imports paths to be in a separate import block. While this issue does not affect the main CoreDNS repo, it can cause unit test failures in forks of CoreDNS that include external third-party plugins. Signed-off-by: Grant Spence <gspence@redhat.com>
gcs278
added a commit
to gcs278/coredns
that referenced
this pull request
Jun 11, 2024
Generate zplugin.go correctly with third-party plugins (coredns#6692) Previously, the generation of zplugin.go would not separate third-party external plugins from CoreDNS plugins in the go import block. This leads to the TestImportOrdering unit test failing, as it requires that third-party imports paths to be in a separate import block. While this issue does not affect the main CoreDNS repo, it can cause unit test failures in forks of CoreDNS that include external third-party plugins. Signed-off-by: Grant Spence <gspence@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Previously, the generation of zplugin.go would not separate third-party external plugins from CoreDNS plugins in the go import block. This leads to the TestImportOrdering unit test failing, as it requires that third-party imports paths to be in a separate import block.
While this issue does not affect the main CoreDNS repo, it can cause unit test failures in forks of CoreDNS that include external third-party plugins.
2. Which issues (if any) are related?
Fixes #6691
3. Which documentation changes (if any) need to be made?
None
4. Does this introduce a backward incompatible change or deprecation?
No