Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate zplugin.go correctly with third-party plugins #6692

Merged

Commits on May 20, 2024

  1. Generate zplugin.go correctly with third-party plugins

    Previously, the generation of zplugin.go would not separate
    third-party external plugins from CoreDNS plugins in the go
    import block. This leads to the TestImportOrdering unit test
    failing, as it requires that third-party imports paths to be
    in a separate import block.
    
    While this issue does not affect the main CoreDNS repo, it can cause
    unit test failures in forks of CoreDNS that include external third-party
    plugins.
    
    Signed-off-by: Grant Spence <gspence@redhat.com>
    gcs278 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0c8e1fa View commit details
    Browse the repository at this point in the history