Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should criteria name markings be changed? #22

Closed
david-a-wheeler opened this issue Sep 15, 2015 · 5 comments
Closed

Should criteria name markings be changed? #22

david-a-wheeler opened this issue Sep 15, 2015 · 5 comments

Comments

@david-a-wheeler
Copy link
Collaborator

Currently criteria are marked with names using square brackets.

In commit 7df076a there's discussion on whether there's a better way. Should names be visible to casual users? (David says yes, Dan is skeptical.) If they are visible, should they be displayed differently (e.g., as smaller superscripted text)? Should these be named anchors, enabling people to jump to specific locations?

@david-a-wheeler
Copy link
Collaborator Author

Commit 5636efd superscripts the names. Does this seem like an improvement? If so, we can text try out creating anchors, and making these names into links to the named anchors (making it easy to get to them later).

@dankohn
Copy link
Contributor

dankohn commented Sep 16, 2015

I like it. Especially once you add the anchor tags. I might also try
superscripting the daggers.

Dan Kohn mailto:dan@dankohn.com
tel:+1-415-233-1000

On Wed, Sep 16, 2015 at 2:12 PM, David A. Wheeler notifications@github.com
wrote:

Commit 5636efd
5636efd
superscripts the names. Does this seem like an improvement? If so, we can
text try out creating anchors, and making these names into links to the
named anchors (making it easy to get to them later).


Reply to this email directly or view it on GitHub
#22 (comment)
.

@altonius
Copy link
Contributor

i too like the superscript.

On Thu, 17 Sep 2015 at 04:16 Dan Kohn notifications@github.com wrote:

I like it. Especially once you add the anchor tags. I might also try
superscripting the daggers.

Dan Kohn mailto:dan@dankohn.com
tel:+1-415-233-1000

On Wed, Sep 16, 2015 at 2:12 PM, David A. Wheeler <
notifications@github.com>
wrote:

Commit 5636efd
<
5636efd

superscripts the names. Does this seem like an improvement? If so, we can
text try out creating anchors, and making these names into links to the
named anchors (making it easy to get to them later).


Reply to this email directly or view it on GitHub
<
#22 (comment)

.


Reply to this email directly or view it on GitHub
#22 (comment)
.

@david-a-wheeler
Copy link
Collaborator Author

Commit b1a8fbe adds the anchor tags, and each name is a link to its anchor. If this makes sense, we can try superscripting the daggers and asterisks next (they'll be really small then!).

@david-a-wheeler
Copy link
Collaborator Author

Commit d8b07e7 moves the daggers and asterisks into the superscript. I think this resolves things. We still have real names listed (which is important to me), but through the subscripts they take less space and are clearly distinguished from the criteria text (which I think addresses Dan's concern). We also have named anchors, and the name includes the named anchor, making it really easy to jump to any of the criteria.

I think we're done, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants