Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old amd module loading issues #3

Closed
wants to merge 1 commit into from

Conversation

AubreyHewes
Copy link

RequireJS/AMD module names may not end with dotjs...

See twitter/typeahead.js#1211

@core-system-dev
Copy link
Contributor

LGTM

/cc @Apfeluser

@lenovouser
Copy link
Contributor

@AubreyHewes Thanks a lot! I had to merge the previous work on v0.11.2 before this one. Could you please rebase?

@AubreyHewes
Copy link
Author

Rebased; problem has been fixed via integration of 212fe89 (anon requirejs module(s); better solution). My pr was possibly based on the latest twitter/release codebase not this repo's latest codebase?

More major problem is that there is no release (bower/npm) with the correct fix..

bower/npm install of "typeahead.js" is the "old" ? twitter repo; I understood this repo was the replacement of the twitter repo? (rename twitter repo to this repo ; bower/bower#120 )

even using this repo there is no tag to get the latest code... needs release tag? ... As can only use via latest/known commit hash..

@core-system-dev
Copy link
Contributor

@AubreyHewes Okay, good to know. We'll try to contact the bower and npm teams about how we should handle this, as twitter might come back and continue supporting their fork in the future. I made a issue for this now. Sorry for the late reply.

#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants