-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform: add support for vultr #451
Conversation
172929a
to
d05652a
Compare
@bh7cw thanks for the PR! Did you manually check whether this produces the expected result on a real Vultr instance? If so, can you please paste as a comment here how does the final attributes-metadata content looks like? |
Test afterburn on vultr:
|
Plus, private network, public network, ipv4, ipv6, and bgp are all optional for instances on vultr and user can chose to use or not. |
Just a minor comment, code looks good otherwise. Thanks for manually testing too! |
@bh7cw is this still WIP or ready for the final pass? |
this adds fetching attrbites and ssh keys from vultr, and tests via mockito. Fixes coreos#343
@lucab Thanks for review. This PR is ready for the final pass. |
@bh7cw thanks for the patch, I did a manual test too and I didn't spot any issue. PR looks good to me, I've re-triggered the CI, will merge once green. |
This adds fetching attributes and ssh keys from vultr, and tests via mockito.
Fixes #343