cmd-virt-install: New wrapper for virt-install #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miabbott
reviewed
Jan 22, 2020
miabbott
reviewed
Jan 22, 2020
miabbott
reviewed
Jan 22, 2020
miabbott
reviewed
Jan 22, 2020
miabbott
approved these changes
Jan 22, 2020
cgwalters
force-pushed
the
run-libvirt
branch
from
efb7dc4
to
de5f5e7
Compare
jlebon
approved these changes
Jan 29, 2020
As the comment says this code is bits we eventually want in the main `virt-install` program. However, my immediate motivation here is to use libvirt with `qemu:///system` to test ipv6. We could also use libvirt for other scenarios of course.
cgwalters
force-pushed
the
run-libvirt
branch
from
de5f5e7
to
b7cdb84
Compare
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
Add in more tags to Fedora Cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment says this code is bits we eventually want
in the main
virt-installprogram. However, my immediatemotivation here is to use libvirt with
qemu:///systemto test ipv6.We could also use libvirt for other scenarios of course.