schema: add ibmcloud to schema #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @darkmuggle for a sanity check |
miabbott
reviewed
Sep 24, 2020
src/schema/v1.json
Outdated
| @@ -183,6 +183,7 @@ | |||
| "pkgdiff", | |||
| "parent-pkgdiff", | |||
| "release-payload", | |||
| "ibmcloud", | |||
There was a problem hiding this comment.
added a second commit to make it alphabetical
|
Minor nit, but otherwise LGTM /approve |
miabbott
reviewed
Sep 24, 2020
dustymabe
force-pushed
the
dusty-ibmcloud-schema
branch
from
e9792ea
to
4f75bf8
Compare
darkmuggle
approved these changes
Sep 24, 2020
dustymabe
force-pushed
the
dusty-ibmcloud-schema
branch
from
4f75bf8
to
4077230
Compare
|
New changes are detected. LGTM label has been removed. |
|
I did a force push to update the CI job for this to also build the IBM Cloud image. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkmuggle, dustymabe, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Sep 25, 2020
Otherwise it's not in the golang generated code. Follow-up to coreos#1740.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 25, 2020
Otherwise it's not in the golang generated code. Follow-up to #1740.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.