Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: start creating ibmcloud artifacts #280

Merged
merged 3 commits into from
Sep 24, 2020

Conversation

dustymabe
Copy link
Member

No description provided.

Copy link
Contributor

@darkmuggle darkmuggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member Author

Thanks. Will merge this once a new COSA has been built with coreos/coreos-assembler#1740

I think this was an oversight in the past and no one noticed because the
cosa buildextend-aws --upload that runs in the "Upload AWS" stage will
build the image if it wasn't already built.
@dustymabe
Copy link
Member Author

OK, I reworked this a bit too because I noticed AWS was missing when I was updating the CI job in the COSA PR. So now I made them be in alphabetical order and I also added AWS to the list.

Copy link
Contributor

@darkmuggle darkmuggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dustymabe dustymabe merged commit 35f1f18 into coreos:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants