Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub: make boot RAID check Petitboot-compatible #2005

Merged
merged 1 commit into from
Jan 15, 2021
Merged

grub: make boot RAID check Petitboot-compatible #2005

merged 1 commit into from
Jan 15, 2021

Conversation

bgilbert
Copy link
Contributor

Petitboot doesn't support -e and doesn't support testing for a bare device without a path component.

https://bugzilla.redhat.com/show_bug.cgi?id=1915540#c7

Petitboot doesn't support -e and doesn't support testing for a bare
device without a path component.

https://bugzilla.redhat.com/show_bug.cgi?id=1915540#c7
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bgilbert
Copy link
Contributor Author

/hold

pending ppc64le testing

@jlebon
Copy link
Member

jlebon commented Jan 14, 2021

/approve

@bgilbert
Copy link
Contributor Author

ppc64le testing isn't ready yet, but this is believed to work and should be harmless. Let's get it into a build.

/hold cancel

@arithx
Copy link
Contributor

arithx commented Jan 15, 2021

/lgtm

@bgilbert
Copy link
Contributor Author

Confirmed that this fixes ppc64le boot.

@manojnkumar
Copy link

/lgtm

@openshift-ci-robot
Copy link

@manojnkumar: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravanelli
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arithx, bgilbert, cgwalters, jlebon, manojnkumar, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [arithx,bgilbert,cgwalters,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e2747d5 into coreos:master Jan 15, 2021
@bgilbert bgilbert deleted the petitboot branch January 15, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants