coreos-assembler/src/cmdlib: rearrange option sequence #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearrange location of '-maxdepth' option to avoid 'find' warning See: coreos#3199
jlebon
previously approved these changes
Nov 17, 2022
We're not shipping this right now and building it broke in the upgrade to OCP 4.11 with: ``` [2022-11-17T16:25:11.894Z] 2022-11-17 16:25:08,317 ERROR - Command returned bad exitcode [2022-11-17T16:25:11.894Z] 2022-11-17 16:25:08,317 ERROR - COMMAND: ['buildah', '--storage-driver', 'vfs', 'from', 'scratch'] [2022-11-17T16:25:11.894Z] 2022-11-17 16:25:08,317 ERROR - STDERR: time="2022-11-17T16:25:08Z" level=warning msg="Reading allowed ID mappings: reading subuid mappings for user \"cosa\" and subgid mappings for group \"cosa\": no subuid ranges found for user \"cosa\" in /etc/subuid" [2022-11-17T16:25:11.894Z] time="2022-11-17T16:25:08Z" level=warning msg="Found no UID ranges set aside for user \"cosa\" in /etc/subuid." [2022-11-17T16:25:11.894Z] time="2022-11-17T16:25:08Z" level=warning msg="Found no GID ranges set aside for user \"cosa\" in /etc/subgid." [2022-11-17T16:25:11.894Z] Error during unshare(CLONE_NEWUSER): Function not implemented ```
|
I pushed up a commit that should fix CI. |
dustymabe
approved these changes
Nov 17, 2022
|
well it didn't pick up the CI changes probably because @c4rt0 is new. I'm just going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearrange location of '-maxdepth' option to eliminate 'find' warning
See: #3199