warning from `find` during `cosa fetch`

[miabbott]

Bug Report

Seeing the following warning while running cosa fetch

find: warning: you have specified the global option -maxdepth after the argument -name, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it. Please specify global options before other arguments.

Environment

What operating system is being used to run coreos-assembler?

Fedora 36

What operating system is being assembled?

FCOS

Is coreos-assembler running in Podman or Docker?

podman

If Podman, is coreos-assembler running privileged or unprivileged?

unprivileged

Expected Behavior

No warnings during the use of cosa fetch

Actual Behavior

See the warning from find below:

$ cosa fetch
...
Deleted rpmostree/pkg/netavark/1.0.3-3.fc36.x86__64             
Deleted rpmostree/pkg/generic-release-common/36-0.1.noarch
Deleted rpmostree/pkg/generic-release/36-0.1.noarch               
Config commit: 5ead31350d18dff997a524643afb6a4332af6853
Using manifest: /srv/src/config/manifest.yaml        
find: warning: you have specified the global option -maxdepth after the argument -name, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
/srv/tmp/override/fedora-coreos-pool.repo  /srv/tmp/override/fedora-next.repo  /srv/tmp/override/fedora-rawhide.repo  /srv/tmp/override/fedora.repo
Committing 05core: /srv/src/config/overlay.d/05core ... 1ae445f7a9fd192fcc04fc1f8331c750a1d7edeeb376914bf73a70abe98e1e5f
...

Reproduction Steps

1. cosa fetch

Additional Information

Just a warning, not fatal to the fetch process as far as I can tell.

[miabbott]

Shows up during cosa build as well

Previous build: 36.20221010.dev.0                    
Previous commit: da8029f34755673edb3a6ab7d1551f90231feeda4b0d83590c90ccafd2e08c7e
Image Config checksum: 1b349be51c1863be55411d56c22df08ec0684219a0698e0e4c96c4dab5c3655a
info: Directory /srv/src/config, is from branch testing-devel, commit 5ead31350d18dff997a524643afb6a4332af6853
find: warning: you have specified the global option -maxdepth after the argument -name, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
/srv/tmp/override/fedora-coreos-pool.repo  /srv/tmp/override/fedora-next.repo  /srv/tmp/override/fedora-rawhide.repo  /srv/tmp/override/fedora.repo

Probably in this code

coreos-assembler/src/cmdlib.sh

Lines 398 to 407 in cfa0a43

	find "${configdir}/" -name '*.repo' -maxdepth 1 -type f -exec cp -t "${tmp_overridesdir}" {} +
	if [ -d "${workdir}/src/yumrepos" ]; then
	find "${workdir}/src/yumrepos/" -maxdepth 1 -type f -name '*.repo' -exec cp -t "${tmp_overridesdir}" {} +
	fi
	if ! ls "${tmp_overridesdir}"/*.repo; then
	echo "ERROR: no yum repo files were found"
	exit 1
	fi
	manifest=${override_manifest}
	fi

[dustymabe]

This was fixed by #3211