tests: choose latest y-stream versioning for rhcos upgrade

[mike-nguyen]

The cincinatti graph is used to determine the latest OCP release. It was assumed that only the latest node would have no upgrade path in the graph but that is not the case. When upgrades are blocked, there can be two nodes that no have upgrade path. We need to choose the newest one in the upgrade test.

[mike-nguyen]

This needs to be backported all the way back to 4.10 since that was when this test was added.

[cgwalters]

I'm honestly not fully following the logic here, but I'm assuming you tested this and it looks sane.

[mike-nguyen]

Added suggestions. Once this is backported to 4.10 we can remove the hack in coreos/coreos-ci-lib#136

[jlebon]

I tested it and added it verbatim. Thanks @jlebon!

Awesome, thanks for testing!

[jlebon]

/cherrypick rhcos-4.12

[jlebon]

/cherrypick rhcos-4.11

[jlebon]

/cherrypick rhcos-4.10

[openshift-cherrypick-robot]

@jlebon: #3266 failed to apply on top of branch "rhcos-4.11":

Applying: tests: choose latest y-stream versioning for rhcos upgrade
Using index info to reconstruct a base tree...
M	mantle/kola/tests/rhcos/upgrade.go
Falling back to patching base and 3-way merge...
Auto-merging mantle/kola/tests/rhcos/upgrade.go
CONFLICT (content): Merge conflict in mantle/kola/tests/rhcos/upgrade.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 tests: choose latest y-stream versioning for rhcos upgrade
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick rhcos-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jlebon: new pull request created: #3294

In response to this:

/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jlebon: #3266 failed to apply on top of branch "rhcos-4.10":

Applying: tests: choose latest y-stream versioning for rhcos upgrade
Using index info to reconstruct a base tree...
M	mantle/kola/tests/rhcos/upgrade.go
Falling back to patching base and 3-way merge...
Auto-merging mantle/kola/tests/rhcos/upgrade.go
CONFLICT (content): Merge conflict in mantle/kola/tests/rhcos/upgrade.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 tests: choose latest y-stream versioning for rhcos upgrade
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick rhcos-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.