Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.11] Add time package as a build dependence #3289

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

ravanelli
Copy link
Member

  • Since it is a small package with only glib as dep, let's add the time package for easily debug cosa related issues.

Signed-off-by: Renata Ravanelli rravanel@redhat.com
(cherry picked from commit 1bd7cfe)

 - Since it is a small package with only glib as dep, let's add the time package
for easily debug cosa related issues.

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
(cherry picked from commit 1bd7cfe)
@dustymabe dustymabe changed the title Add time package as a build dependence [rhcos-4.11] Add time package as a build dependence Dec 16, 2022
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2022

@ravanelli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos b546dbc link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Dec 16, 2022

Prow is failing on

 --- FAIL: rhcos.upgrade.from-ocp-rhcos (3.73s)
        upgrade.go:215: invalid character '<' looking for beginning of value 

We'll have that fixed once #3266 is backported.

But for now, we can merge this. It's clearly not related to this PR.

@jlebon jlebon merged commit fffac73 into coreos:rhcos-4.11 Dec 16, 2022
@ravanelli ravanelli deleted the time_4.11 branch June 1, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants