tweak system and os_type for OVA #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcrow
approved these changes
May 22, 2019
|
This should also be backported to the |
|
#529 is the backport |
dustymabe
reviewed
May 22, 2019
| memory=4096, system_type="vmx-07 vmx-08", | ||
| os_type="other26xLinux64Guest", scsi="VirtualSCSI", | ||
| memory=4096, system_type="vmx-13", | ||
| os_type="rhel7_64Guest", scsi="VirtualSCSI", |
There was a problem hiding this comment.
Is this the right value for non-RHEL based systems (i.e. Fedora)
There was a problem hiding this comment.
Great point. In my haste to get this through I did not check on that.
|
ESXi 6.0 is supported for another year. For FCOS, we may want to consider running on it, which would require setting hardware version 11. |
|
Filed coreos/fedora-coreos-tracker#185 to decide whether to support 6.0 in FCOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were both suggested by contacts at VMWare.
The change here to the "vmx" value will prevent the OVA from being used on ESX versions that are older than what we are prepared to support, and is thus a desirable change from a customer experience perspective.
The OS change may be more cosmetic. Eventually there will also be a "rhel8" equivalent, which we may want to switch to.