Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak system and os_type for OVA #529

Merged

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented May 22, 2019

Backport of #528

@ashcrow ashcrow added bug Something isn't working enhancement New feature or request labels May 22, 2019
@ashcrow ashcrow requested review from imcleod and miabbott May 22, 2019 17:40
@imcleod
Copy link
Contributor

imcleod commented May 22, 2019

/lgtm

Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashcrow ashcrow merged commit 000b551 into coreos:rhcos-4.1 May 22, 2019
@bgilbert
Copy link
Contributor

Noting for the record that this is not a cosmetic change.

@imcleod
Copy link
Contributor

imcleod commented May 22, 2019

My read of that page, initially, is that newer HW revisions have higher limits on certain resources, and a larger set of available virtual HW more generally.

I can't see anything net-new on the v13 hardware that we are attempting to use in our OVA, and our memory and CPU settings are, of course, not hitting the limits.

Do we/you have actual examples of an OVA that is otherwise identical in terms of size and virtual HW configuration, that actually behaved differently just because of the change in virtual HW version?

@bgilbert
Copy link
Contributor

Yes, coreos/bugs#1583. That was in the opposite direction, of course; my point is that virtual hardware changes can exercise different code paths in the kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants