This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10.0.0.0/14 is really really popular for folks to already have in their infrastructure. If one wanted to vpc peer to the kubernetes cluster, it would be difficult with 10.0.0.0/14. 172.20.0.0/14 is probably less popular & more likely to just work.
Creating this patch shows that we need a way to have these network IP addresses & CIDRs as cluster.yaml settings & not hard coded into go & misc files. I will make sure there's an issue for this concern.