Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

app-emulation/qemu: add qemu to improve streamOptimized vmdk support for VMware OVF #1009

Closed
wants to merge 1 commit into from

Conversation

higebu
Copy link
Contributor

@higebu higebu commented Dec 15, 2014

Fixes coreos/bugs#176.

I added the patch to improve streamOptimized vmdk support.
If we don't use it, we can't deploy OVF to ESXi or vCenter.

For more details:
http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg01151.html

@higebu
Copy link
Contributor Author

higebu commented Dec 15, 2014

This PR is related to coreos/scripts#362.

@marineam
Copy link
Contributor

Overall style wise, could you prune extra bits like the Gentoo ChangeLog and the live (-9999) ebuild? They just add clutter making it harder to see what the exact local changes are and the live ebuild can continue to live in the portage-stable repo.

On the patch itself, could you include the original commit message and a link in header? As is it isn't obvious which revision of the patch you used, the last appears to be this one: http://lists.gnu.org/archive/html/qemu-devel/2014-08/msg01028.html

It is a rather large patch for code that I don't understand and unfortunately never finished review so I'm a little reluctant to accept it unless it gets back on track to merge upstream. I assume the author has moved on but it would be worthwhile to track down Milos Vyletel to see if he intends to finish it or if the patch needs a new champion to finish it. The final round of comments seem relatively strait forward so hopefully there isn't much left to do. http://lists.gnu.org/archive/html/qemu-devel/2014-08/msg02809.html

@higebu
Copy link
Contributor Author

higebu commented Dec 15, 2014

Thank you for your review.
Changes are following:

  • Use v3 patch.
  • Add original commit message and link to patch.
  • Remove ChangeLog, qemu-9999.ebuild and metadata.xml.
  • Generate Manifest.

I hope that Milos Vyletel gets back and his patch is merged to upstream too.

@marineam
Copy link
Contributor

Thanks for working on this but VMware is providing a different tool to create the proper VMDK format and OVA which should be a better way forward than this patch.

#1015

@marineam marineam closed this Dec 17, 2014
@higebu
Copy link
Contributor Author

higebu commented Dec 17, 2014

I didn't know open-vmdk project. I think VMware's PR is better than this too.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants