Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

sys-kernel/bootengine: bump to fix AWS/GCE disks #3456

Merged
merged 1 commit into from
Oct 30, 2018
Merged

sys-kernel/bootengine: bump to fix AWS/GCE disks #3456

merged 1 commit into from
Oct 30, 2018

Conversation

r7vme
Copy link
Contributor

@r7vme r7vme commented Oct 26, 2018

This change includes bootengine with fix for
AWS/GCE disks in ignition.

coreos/bootengine#149

Related bug: coreos/bugs#2481

@lucab
Copy link
Contributor

lucab commented Oct 26, 2018

@dm0- do we need to introduce any dependency here between bootengine and nmve-cli ebuilds?

@dm0-
Copy link
Contributor

dm0- commented Oct 26, 2018

Yeah, I guess that would be a good idea. Right now nvme-cli is only brought it by the overall coreos metapackage, so in theory, the kernel ebuild could try to generate an initramfs before it's installed. (In practice, the kernel is usually one of the last packages to build because the modules package takes so long.) So, specifically I think the dependency could be added on the two sys-kernel/coreos-kernel ebuilds.

@r7vme
Copy link
Contributor Author

r7vme commented Oct 30, 2018

Ignore. Seems both sys-kernel/coreos-kernel already have bootengine dependencies


Is it what we were looking for?

This change includes bootengine with fix for
AWS/GCE disks in ignition. It also adds sys-apps/nvme-cli
dependency to sys-kernel/coreos-kernel.

coreos/bootengine#149
@r7vme
Copy link
Contributor Author

r7vme commented Oct 30, 2018

PTAL

Added sys-apps/nvme-cli as dependency to both sys-kernel/coreos-kernel ebuilds.

@lucab
Copy link
Contributor

lucab commented Oct 30, 2018

No further comments from my side, @dm0- feel free to merge whenever suitable. Thanks a lot @r7vme for pushing this forward!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants