This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
cluster: handle invalid member name #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Jan 1, 2017
| @@ -17,5 +17,6 @@ package cluster | |||
| import "errors" | |||
|
|
|||
| var ( | |||
| errNoBackupExist = errors.New("no backup exist for disaster recovery") | |||
| errNoBackupExist = errors.New("no backup exist for disaster recovery") | |||
| errInvalidMemberName = errors.New("member's Name has the wrong format") | |||
There was a problem hiding this comment.
the format of member's name is invalid.
xiang90
reviewed
Jan 1, 2017
| @@ -64,3 +71,12 @@ func podsToMemberSet(pods []*api.Pod, selfHosted *spec.SelfHostedPolicy) etcduti | |||
| } | |||
| return members | |||
| } | |||
|
|
|||
| func findID(name string) (int, error) { | |||
There was a problem hiding this comment.
probably move this to etcdutil/member
member.NameID()
There was a problem hiding this comment.
The logic of naming convention all sits in pkg/cluster:
https://github.com/coreos/etcd-operator/blob/master/pkg/cluster/cluster.go#L297
Can we put it in the same pkg right now? I have another PR ontop.
We would centralize such logic, probably in etcdutil/member later.
|
fix error message. |
|
@etcd-bot retest this please An etcd pod keeps pending. Seems like a normal cluster flake: |
|
Merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.