Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: identify and mark non-exclusive tests #1229

Closed
dustymabe opened this issue Sep 22, 2021 · 2 comments
Closed

tests: identify and mark non-exclusive tests #1229

dustymabe opened this issue Sep 22, 2021 · 2 comments
Assignees
@Adam0Brien
Labels
good first issue Good for newcomers jira For syncing to Jira. Only works for issues (i.e. not PRs)

Comments

@dustymabe
Copy link
Member

Now that we support combining non-exclusive tests into a single VM let's identify other tests that we have written in our external tests within this repo (other than misc-ro and misc-ign-ro) that aren't exclusive and can be marked as exclusive: false).
@dustymabe dustymabe changed the title tests: identify non-exclusive tests tests: identify and mark non-exclusive tests Sep 22, 2021
@dustymabe dustymabe added the jira For syncing to Jira. Only works for issues (i.e. not PRs) label Sep 22, 2021
@saqibali-2k saqibali-2k added the good first issue Good for newcomers label Oct 12, 2021
@saqibali-2k
Copy link
Member

The general workflow here is:

  • Find a test that you think is non-exclusive and modify the kola.json file or tag with a exclusive: false key-value.
  • Run non-exclusive tests to verify that tests are still passing and that the test we changed is non-exclusive

Reminder: we can use cosa kola run <blob pattern> to run a specific test or a group of tests.

@dustymabe dustymabe mentioned this issue Aug 31, 2022
Closed
@Adam0Brien Adam0Brien self-assigned this Feb 23, 2023
Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Feb 28, 2023
Added exclusive: false to kola tests
5a5b92f 
Fix: coreos#1229
@Adam0Brien Adam0Brien mentioned this issue Feb 28, 2023
Closed
@Adam0Brien
Copy link
Member

Adam0Brien commented Mar 2, 2023 •
edited

no additional tests needed to be marked as exclusive false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam0Brien Adam0Brien

Labels
good first issue Good for newcomers jira For syncing to Jira. Only works for issues (i.e. not PRs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dustymabe @saqibali-2k @Adam0Brien