tests: identify and mark non-exclusive tests #2265
Conversation
| @@ -34,7 +34,7 @@ case ${arch} in | |||
| device=$(realpath /dev/disk/by-partlabel/PowerPC-PReP-boot) | |||
| # sync grub2-install parameter according to image build script | |||
| # https://github.com/coreos/coreos-assembler/blob/main/src/create_disk.sh | |||
| grub_install_args="--no-nvram" | |||
| grub_install_args="--no-nvram" | |||
There was a problem hiding this comment.
It's not a big deal here, but normally we'd put formatting changes in a separate commit.
There was a problem hiding this comment.
sorry about that, i have vs code set up to auto trim white space..
I think probably a safe rule of thumb here is that if a test has a butane config (or Ignition config) then we should probably assume it's exclusive and not mark it Maybe that means that there are no remaining tests to mark as exclusive? I'm not sure |
tests/kola/gshadow
Outdated
| @@ -20,3 +20,4 @@ echo 'grp1:*::somebody.a1,somebody.a2,somebody.a3,somebody.a4,somebody.a5,somebo | |||
| echo 'grp2:*::root' >> /etc/gshadow | |||
| systemd-sysusers | |||
| echo "ok sysusers gshadow" | |||
|
|
|||
There was a problem hiding this comment.
this isn't a meaningful change.. delete?
There was a problem hiding this comment.
This originally added a newline and is now removing one. On Unix systems, text files traditionally end with a single newline.
Also, if there are reboots, the test may be changing the system, or at least is distinguishing between first and second boots. Multiple tests can't do that, either in series or in parallel. |
|
All of the remaining tests specify test-specific kernel arguments, and some also configure additional network devices. I think we should probably just close this. |
Yeah probably. Sorry Adam for the goose chase. At least we can probably close #1229 now. |
No problem still learned alot about kola tests 👍 |
Added Exclusive false to kola tests to make it easier to distinguish what tests can run together in a single vm.
#1229