Copy rootfs Ignition mountOptions to rootflags karg #805

bgilbert · 2021-01-05T08:18:57Z

Hmm, I think if we have magic for reprovisioning root, then we should also just handle mount_options too and translate that into rootflags. This is similar to how with_mount_unit also injects the mount options into the unit.

Originally posted by @jlebon in #503 (comment)

The text was updated successfully, but these errors were encountered:

By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have coreos#805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704

By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have #805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704

Right now, specifying `mountOptions` for the rootfs in the Ignition config is ignored. To fix that, we simply need to have `coreos-rootflags` inspect the Ignition config if the rootfs was reprovisioned and extract the field. This then takes effect on first boot (via `ignition-ostree-mount-sysroot.sh` calling out to it) and subsequent boots (via `rdcore rootmap` calling out to `coreos-rootflags`). Closes: coreos#805

By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have coreos#805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704 (cherry picked from commit a57a999)

By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have #805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704 (cherry picked from commit a57a999)

Right now, specifying `mountOptions` for the rootfs in the Ignition config is ignored. To fix that, we simply need to have `coreos-rootflags` inspect the Ignition config if the rootfs was reprovisioned and extract the field. This then takes effect on first boot (via `ignition-ostree-mount-sysroot.sh` calling out to it) and subsequent boots (via `rdcore rootmap` calling out to `coreos-rootflags`). Closes: #805

By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have coreos#805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704

Right now, specifying `mountOptions` for the rootfs in the Ignition config is ignored. To fix that, we simply need to have `coreos-rootflags` inspect the Ignition config if the rootfs was reprovisioned and extract the field. This then takes effect on first boot (via `ignition-ostree-mount-sysroot.sh` calling out to it) and subsequent boots (via `rdcore rootmap` calling out to `coreos-rootflags`). Closes: coreos#805

By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have coreos#805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704

Right now, specifying `mountOptions` for the rootfs in the Ignition config is ignored. To fix that, we simply need to have `coreos-rootflags` inspect the Ignition config if the rootfs was reprovisioned and extract the field. This then takes effect on first boot (via `ignition-ostree-mount-sysroot.sh` calling out to it) and subsequent boots (via `rdcore rootmap` calling out to `coreos-rootflags`). Closes: coreos#805

jlebon mentioned this issue Mar 19, 2021

overlay: always use prjquota for XFS rootfs #903

Merged

jlebon added the jira For syncing to Jira. Only works for issues (i.e. not PRs) label Mar 19, 2021

jlebon self-assigned this Mar 19, 2021

jlebon mentioned this issue Mar 19, 2021

overlay: propagate rootfs mountOptions to rootflags karg #904

Merged

jlebon closed this as completed in #904 Mar 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy rootfs Ignition mountOptions to rootflags karg #805

Copy rootfs Ignition mountOptions to rootflags karg #805

bgilbert commented Jan 5, 2021 •

edited

Copy rootfs Ignition mountOptions to rootflags karg #805

Copy rootfs Ignition mountOptions to rootflags karg #805

Comments

bgilbert commented Jan 5, 2021 • edited

bgilbert commented Jan 5, 2021 •

edited