overlay: always use prjquota for XFS rootfs #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, we mount XFS with the `prjquota` option. Verify this.
We should have those in a shared shell library.
jlebon
force-pushed
the
pr/prjquota-always
branch
from
86aa97c
to
406338a
Compare
arithx
reviewed
Mar 19, 2021
By default, we use `prjquota` for the rootfs for container orchestrators to monitor and set drive space limits. However, with the added support for rootfs reprovisioning, we made this conditional on the rootfs not being reprovisioned, with the assumption that you can just set whatever options you'd like instead. Though actually doing that is really awkward right now, and it requires surfacing prjquota in user documentations (see https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2). Since AFAICT `prjquota` doesn't actually have any significant overhead, let's just simplify the messaging to: we *always* enable prjquota on XFS root filesystems. Users who want to override this can fallback to `rpm-ostree kargs` (and eventually once we have coreos#805, to `mountOptions: []`). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704
jlebon
force-pushed
the
pr/prjquota-always
branch
from
406338a
to
a6ec043
Compare
arithx
approved these changes
Mar 19, 2021
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Mar 19, 2021
I.e. coreos/fedora-coreos-config#900 (for https://bugzilla.redhat.com/show_bug.cgi?id=1934863) and coreos/fedora-coreos-config#903 (for https://bugzilla.redhat.com/show_bug.cgi?id=1940966). ``` Jonathan Lebon (8): overrides: pin to kernel-5.10.19-200.fc33 for rootless podman image.yaml: bump virtual disk images to 10G manifest: use `mkdir -p` for resolved.conf.d/ dir overlay: don't restamp rootfs UUID if reprovisioning overlay/growfs: handle broken lsblk in el8 tests/misc-ro: check for prjquota tests/root-reprovision: use `ok` and `fatal` helpers overlay: always use prjquota for XFS rootfs Luca BRUNO (2): fedora-coreos-base: add nm-cloud-setup, forward platform variables lockfile: refresh after manifest changes Sohan Kunkerkar (1): overrides: fast-track coreos-installer 0.8.0 ```
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Mar 19, 2021
I.e. coreos/fedora-coreos-config#900 (for https://bugzilla.redhat.com/show_bug.cgi?id=1934863) and coreos/fedora-coreos-config#903 (for https://bugzilla.redhat.com/show_bug.cgi?id=1940966). ``` Jonathan Lebon (5): overlay: don't restamp rootfs UUID if reprovisioning overlay/growfs: handle broken lsblk in el8 tests/misc-ro: check for prjquota tests/root-reprovision: use `ok` and `fatal` helpers overlay: always use prjquota for XFS rootfs ```
|
Nice work on this! Hmm. Definitely a bit of a philosophical issue here. I feel like if we could go back to the start, arguably we might have not enabled |
miabbott
pushed a commit
to jlebon/os
that referenced
this pull request
Mar 22, 2021
I.e. coreos/fedora-coreos-config#900 (for https://bugzilla.redhat.com/show_bug.cgi?id=1934863) and coreos/fedora-coreos-config#903 (for https://bugzilla.redhat.com/show_bug.cgi?id=1940966). ``` Jonathan Lebon (5): overlay: don't restamp rootfs UUID if reprovisioning overlay/growfs: handle broken lsblk in el8 tests/misc-ro: check for prjquota tests/root-reprovision: use `ok` and `fatal` helpers overlay: always use prjquota for XFS rootfs ```
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
`image.yaml` updates for RHEL 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we use
prjquotafor the rootfs for container orchestratorsto monitor and set drive space limits.
However, with the added support for rootfs reprovisioning, we made this
conditional on the rootfs not being reprovisioned, with the assumption
that you can just set whatever options you'd like instead. Though
actually doing that is really awkward right now, and it requires
surfacing prjquota in user documentations (see
https://bugzilla.redhat.com/show_bug.cgi?id=1940704#c2).
Since AFAICT
prjquotadoesn't actually have any significant overhead,let's just simplify the messaging to: we always enable prjquota on XFS
root filesystems. Users who want to override this can fallback to
rpm-ostree kargs(and eventually once we have#805, to
mountOptions: []).Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940704