tests: add tests for systemd reading files labeled kubernetes_file_t #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This builds on #1064 and will require a new |
miabbott
force-pushed
the
kube_envfile_test
branch
from
5edc637
to
be1eff6
Compare
miabbott
force-pushed
the
kube_envfile_test
branch
2 times, most recently
from
0586220
to
44fc622
Compare
|
@dustymabe @mike-nguyen tagging you to pop this closer to the top of your queues |
dustymabe
reviewed
Jan 7, 2022
| echo "$@" >&2 | ||
| exit 1 | ||
| } | ||
|
|
There was a problem hiding this comment.
I would add an additional check here to make sure the file at /etc/kubernetes/envfile has the selinux label we expect. Otherwise this test isn't really testing what we expect it to.
dustymabe
previously approved these changes
Jan 7, 2022
Adds a test for the ability of `systemd` to read files labeled with `kubernetes_file_t`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1973418
miabbott
force-pushed
the
kube_envfile_test
branch
from
44fc622
to
a2a83a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for the ability of
systemdto read fileslabeled with
kubernetes_file_t.See: https://bugzilla.redhat.com/show_bug.cgi?id=1973418