[testing-devel] lockfiles: drop graduated overrides 🎓

[coreosbot-releng]

Triggered by remove-graduated-overrides GitHub Action.

[bgilbert]

[2022-01-27T01:44:45.158Z] Downgraded:
[2022-01-27T01:44:45.158Z]   polkit 0.120-1.fc35.1 -> 0.120-1.fc35
[2022-01-27T01:44:45.158Z]   polkit-libs 0.120-1.fc35.1 -> 0.120-1.fc35

[dustymabe]

I can only assume this means that NVR comparison gives the answer that 0.120-1.fc35 is newer than 0.120-1.fc35.1 and thus the version in the release day repo is winning

[jlebon]

I think the issue here is a little more subtle. When this workflow ran, https://bodhi.fedoraproject.org/updates/FEDORA-2022-da040e6b94 was already pushed to stable so I think it did really see .1 and favoured it. The problem is that the base lockfiles themselves did not yet match what was in the overrides. They eventually converge via bump-lockfile: this push bumps polkit to match the override. But CI here ran before that push and so pulled in the old polkit.

This doesn't happen often because overrides usually live long enough for bump-lockfile to run at least once. Thankfully, the CI downgrade check catches it! 🎉

Probably simplest fix for this is to enhance the script to only consider fast-tracked overrides where the version in the base matches.

Anyway, I've restarted CI here which should pass now.

[jlebon]

Probably simplest fix for this is to enhance the script to only consider fast-tracked overrides where the version in the base matches.

Unless someone else (@bgilbert maybe?) wants to, I can tackle this after #1441 merges.

[jlebon]

Not auto-merging so we sanity-check on top of CI that polkit is no longer being downgraded (see #1452 (comment)).