overlay: always use -p with blkid
#2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `blkid` will return cached data, which we don't want because it might be stale. Add `-p` to make sure we always bypass the cache. Some of these callsites could probably be changed to use `lsblk`, which uses the udev database, but it's safer to keep using `blkid`. See also: coreos#2181 (comment)
|
should we not revert e41fd27 as part of this? |
Once this and coreos/coreos-installer#1094 are in. I'll stage a revert PR. |
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Jan 19, 2023
…D restamp" This reverts commit e41fd27. We shouldn't need this anymore now that we don't rely on the cache: - coreos#2184 - coreos/coreos-installer#1094 See also: coreos#2181
jlebon
added a commit
that referenced
this pull request
Mar 31, 2023
…D restamp" This reverts commit e41fd27. We shouldn't need this anymore now that we don't rely on the cache: - #2184 - coreos/coreos-installer#1094 See also: #2181
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
May 17, 2023
…D restamp" This reverts commit e41fd27. We shouldn't need this anymore now that we don't rely on the cache: - coreos#2184 - coreos/coreos-installer#1094 See also: coreos#2181
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
…D restamp" This reverts commit e41fd27. We shouldn't need this anymore now that we don't rely on the cache: - coreos#2184 - coreos/coreos-installer#1094 See also: coreos#2181
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
…D restamp" This reverts commit e41fd27. We shouldn't need this anymore now that we don't rely on the cache: - coreos#2184 - coreos/coreos-installer#1094 See also: coreos#2181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
blkidwill return cached data, which we don't want because it might be stale. Add-pto make sure we always bypass the cache. Some of these callsites could probably be changed to uselsblk, which uses the udev database, but it's safer to keep usingblkid.See also: #2181 (comment)