Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ignition-ostree-firstboot-uuid: nuke libblkid cache after UUID restamp" #2187

Merged
merged 1 commit into from Mar 31, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jan 19, 2023

This reverts commit e41fd27.

We shouldn't need this anymore now that we don't rely on the cache:

See also: #2181

…D restamp"

This reverts commit e41fd27.

We shouldn't need this anymore now that we don't rely on the cache:
- coreos#2184
- coreos/coreos-installer#1094

See also: coreos#2181
@jlebon
Copy link
Member Author

jlebon commented Jan 19, 2023

Requires the linked PRs to land in FCOS.

@dustymabe
Copy link
Member

Requires the linked PRs to land in FCOS.

and at least for the coreos-installer case, the new release to be cut and land in both FCOS and RHCOS.

@jlebon jlebon marked this pull request as ready for review March 22, 2023 20:31
@jlebon
Copy link
Member Author

jlebon commented Mar 22, 2023

This should be unblocked now. Started a fresh CI run.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 668d24e into coreos:testing-devel Mar 31, 2023
@jlebon jlebon deleted the pr/revert-blkid-cache branch March 31, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants