Move conditional network startup from ignition-dracut #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're about to put non-firstboot things in there.
The mechanism for starting network is too distro-specific to live in ignition-dracut. In addition, PXE rootfs fetch will need to invoke the same machinery. Add a unit with triggering conditions for the cases that need network, and use After=ignition-fetch-offline.service to force that service to run early enough.
This was referenced Jul 22, 2020
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
Update for RHEL 8.4 Beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism for starting network is too distro-specific to live in ignition-dracut. In addition, PXE rootfs fetch will need to invoke the same machinery. Add a unit with triggering conditions for the cases that need network, and use
After=ignition-fetch-offline.serviceto force that service to run early enough.Safe to merge before coreos/ignition-dracut#200 lands in the distro.