Move Ignition-Dracut into Ignition #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy Ignition base/user configs from OEM to Ignition system dir
The "After=disk-uuid.service" in ignition-setup.service doesn't actually work because disk-uuid.service is templated. Instead, disk-uuid@.service should sequence itself Before units that access device nodes. Sequence disk-uuid@ Before ignition-setup, and remove "After=disk-uuid.service" from Ignition units.
dracut: correctly sequence disk-uuid@ before ignition-setup
The kernel will automatically bond it to the synthetic interface, so ensure networkd doesn't try to configure it separately.
dracut: ignore Azure SR-IOV VF interface
automated PR: update CoC and legalese
The current invocation is broken (should be $env{DEVLINKS}) and
pointless, so drop it. The last arguments to the `mdadm --incremental`
command are just aliases that can be used in /etc/mdadm.conf (see the
"INCREMENTAL MODE" section of man 8 mdadm). We don't use
/etc/mdadm.conf in the initramfs, so just drop it.
99start-root: drop DEVLINKS from mdadm invocation
Fixed upstream in systemd/systemd@e1c42e1.
dracut: drop obsolete comment
This reverts commit 61f8967.
Alter ignition-generator to only run ignition when coreos.first_boot is present on the command line, add a base Ignition config that removes coreos.first_boot from the grub config, add coreos.first_boot to the grub config in the instructions in README.txt
Also reformat ignition-quench.ign to be more readable
Only run on first boot, enable the disks stage
README: Note instructions are for classic systems
Added a few binaries and also a few modules.
ignition-check-neednet.sh knows too much about distro-level networking configuration. In addition, other things in the initramfs might want to conditionally enable networking, and they'd currently need to reimplement ignition-check-neednet.sh to do so. Instead, let the distro provide its own unit that checks for /run/ignition/neednet. That unit can use dependencies to sequence ignition-fetch-offline.service correctly for its own needs.
|
Overall big +1 on the idea! |
|
The CI failure on this is expected since Local test: |
|
This roughly looks good to me! Some things that popped out:
|
I think that we can coordinate this with @bgilbert's proposed changes easily.
Ah, good catch. I did that in my first experiment but after an unreconcilable rebase I re-did it and missed it. Repushed. |
Move conditional network startup out of ignition-dracut
darkmuggle
force-pushed
the
merged
branch
3 times, most recently
from
dcfabba
to
1d4053b
Compare
darkmuggle
changed the title
|
With coreos/fedora-coreos-config#526 the packaging repo [1] and build [2] this passes Kola. All tests passed. Ready for review. |
added 2 commits
July 23, 2020 17:17
The CoreOS specific modules have been moved to https://github.com/coreos/fedora-coreos-config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dracut: remove CoreOS specific bits from Dracut
CoreOS specific modules have been will be moved over https://github.com/coreos/fedora-coreos-config.
The approach came from coreos/fedora-coreos-tracker#511