Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next-devel] overrides: fast-track selinux-policy 3.14.6-29 #701

Merged
merged 1 commit into from
Oct 20, 2020
Merged

[next-devel] overrides: fast-track selinux-policy 3.14.6-29 #701

merged 1 commit into from
Oct 20, 2020

Conversation

sohankunkerkar
Copy link
Member

@dustymabe
Copy link
Member

Hey @sohankunkerkar - Thanks for working on this. I'm hoping CI passes on it.

After we get CI passing on this PR with this set of changes I think we need to split the PR up because of the way we do config merging (with the bot). Here's what I think we need to do:

  • 1st commit: overrides: fast-track selinux-policy
    • keep in this PR
  • 2nd commit: overlay.d: remove 21dhcp-chrony
    • open a new PR against testing-devel, we have to hold it until we switch testing-devel to f33
  • 3rd commit: kola-denylist: remove ext.config.chrony.dhcp-propagation test from the list
    • open a new PR against testing-devel, we'll merge it and it will get synced to next-devel

Let's wait to make these changes after we verify CI is passing with the existing 3 commits in this PR.

@dustymabe
Copy link
Member

CI passed!

@sohankunkerkar sohankunkerkar changed the title [WIP] chrony-dhcp work for F-33 overrides: fast-track selinux-policy 3.14.6-29 Oct 20, 2020
@sohankunkerkar sohankunkerkar changed the title overrides: fast-track selinux-policy 3.14.6-29 [next-devel] overrides: fast-track selinux-policy 3.14.6-29 Oct 20, 2020
dustymabe
dustymabe approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit f670a63 into coreos:next-devel Oct 20, 2020
@sohankunkerkar sohankunkerkar mentioned this pull request Oct 20, 2020
Merged
@sohankunkerkar sohankunkerkar deleted the chrony-dhcp-fix branch October 20, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sohankunkerkar @dustymabe