Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce official ppc64le architecture artifacts #987

Closed
mkumatag opened this issue Oct 1, 2021 · 13 comments
Closed

Produce official ppc64le architecture artifacts #987

mkumatag opened this issue Oct 1, 2021 · 13 comments
Assignees
Labels
jira for syncing to jira kind/enhancement

Comments

@mkumatag
Copy link

mkumatag commented Oct 1, 2021

Describe the enhancement

This issue for requesting ppc64le platform support for the Fedora CoreOS. Recently arm64 support has been added via #13, this issue forked from the #13 (comment) discussion.

cc @travier

@dustymabe
Copy link
Member

crosslinking coreos/coreos-assembler#2473 here since there is some good discussion there about some challenges ahead.

@dustymabe dustymabe changed the title ppc64le support for Fedora CoreOS produce official ppc64le artifacts Feb 1, 2022
@dustymabe dustymabe self-assigned this Aug 17, 2022
@dustymabe dustymabe added jira for syncing to jira status/pending-testing-release Fixed upstream. Waiting on a testing release. labels Aug 17, 2022
@dustymabe
Copy link
Member

Marking this as complete as it should land in next week's releases.

@dustymabe
Copy link
Member

Actually, we probably need to try to make sure we get coreos/fedora-coreos-config#1844 in on Monday before we start the releases. On my existing builder I'm short on space in /boot:

[core@buildvm-ppc64le-fcos01 srv]$ rpm-ostree status 
State: idle
Deployments:
● ostree-unverified-image:oci-archive:/srv/fedora-coreos-36.20220809.20.3-ostree.ppc64le.ociarchive
                   Digest: sha256:98ed9b1277677bff0455a937c85816ebd3431d38dcebe2bfbdfb66ee7646c0e0
                  Version: 36.20220809.20.3 (2022-08-10T20:09:39Z)

  ostree-unverified-image:oci-archive:/srv/fedora-coreos-36.20220711.dev.0-ostree.ppc64le.ociarchive
                   Digest: sha256:44122282e785ad742350b3862ebbffb5d60a1c8ab4168237c27d4d1efaeb94c3
                  Version: 36.20220711.dev.0 (2022-07-11T08:20:40Z)
[core@buildvm-ppc64le-fcos01 srv]$ 
[core@buildvm-ppc64le-fcos01 srv]$ df -kh /boot/
Filesystem      Size  Used Avail Use% Mounted on
/dev/vda3       362M  248M   92M  74% /boot
[core@buildvm-ppc64le-fcos01 srv]$ 
[core@buildvm-ppc64le-fcos01 srv]$ sudo du -sh /boot/ostree/*
121M    /boot/ostree/fedora-coreos-4629dab1861e40544bb601f84b5fd6ab6fc20a223e76df751bb67d3a2620bbaf
121M    /boot/ostree/fedora-coreos-49d9a2f5d0cc617e86c58c895447654c1c5d563384ee96affba8ad5a1bc019e4

@jlebon
Copy link
Member

jlebon commented Aug 22, 2022

[core@buildvm-ppc64le-fcos01 srv]$ df -kh /boot/
Filesystem      Size  Used Avail Use% Mounted on
/dev/vda3       362M  248M   92M  74% /boot
[core@buildvm-ppc64le-fcos01 srv]$ 
[core@buildvm-ppc64le-fcos01 srv]$ sudo du -sh /boot/ostree/*
121M    /boot/ostree/fedora-coreos-4629dab1861e40544bb601f84b5fd6ab6fc20a223e76df751bb67d3a2620bbaf
121M    /boot/ostree/fedora-coreos-49d9a2f5d0cc617e86c58c895447654c1c5d563384ee96affba8ad5a1bc019e4

Right, this is worse on ppc64le (one of the reasons #1247 was filed was for that arch, where nodes actually did hit ENOSPC). Although we'll have to deal with that in RHCOS for existing machines, for FCOS we have an opportunity to start off ppc64le with a larger /boot already (and we really should've done that for the recently added arches too).

Maybe let's add support for configuring it via image.yaml? We'll need a knob like that anyway to ratchet changing the boot partition size.

@dustymabe
Copy link
Member

for FCOS we have an opportunity to start off ppc64le with a larger /boot already (and we really should've done that for the recently added arches too).

yeah I'm fine with that as long as we have some concensus on what we want things to look like for all architectures before we make any changes here.

I'll try to hold this until we make that decision.

@dustymabe
Copy link
Member

dustymabe commented Sep 16, 2022

Update: coreos/fedora-coreos-config#1844 landed. Here is what I see on our ppc64le builder now (after deploying 36.20220916.20.1):

$ pwd
/boot/ostree
$ sudo du -sh ./* 
112M    ./fedora-coreos-39dc2f20c9a2c1a9a427fd7a0bc456956f3d90c6ed96beeb946c24779e0af338
121M    ./fedora-coreos-d02361e161cc8b1bc393f3686b403f3d5f4fb587853234e1139c1f0d9db38aba
$ file ./fedora-coreos-39dc2f20c9a2c1a9a427fd7a0bc456956f3d90c6ed96beeb946c24779e0af338/initramfs-5.19.8-200.fc36.ppc64le.img 
./fedora-coreos-39dc2f20c9a2c1a9a427fd7a0bc456956f3d90c6ed96beeb946c24779e0af338/initramfs-5.19.8-200.fc36.ppc64le.img: Zstandard compressed data (v0.8+), Dictionary ID: None


$ file ./fedora-coreos-d02361e161cc8b1bc393f3686b403f3d5f4fb587853234e1139c1f0d9db38aba/initramfs-5.18.19-200.fc36.ppc64le.img 
./fedora-coreos-d02361e161cc8b1bc393f3686b403f3d5f4fb587853234e1139c1f0d9db38aba/initramfs-5.18.19-200.fc36.ppc64le.img: gzip compressed data, max compression, from Unix, original size modulo 2^32 1024
$ df -kh /boot/
Filesystem      Size  Used Avail Use% Mounted on
/dev/vda3       362M  239M  101M  71% /boot

@dustymabe
Copy link
Member

dustymabe commented Oct 17, 2022

Here's a summary of what's blocking this right now: #1247 (comment)

UPDATE: The space issue in boot ended up being because the kernel is uncompressed, not because the initramfs file was larger: #1247 (comment)

@dustymabe
Copy link
Member

As a group we have decided to ultimately increase the size of our /boot partition. We should consider releasing ppc64le with the new partition size (once we know what that will be) from the start.

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 25, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 25, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 31, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 31, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
@dustymabe
Copy link
Member

Now that we have OSTree early/auto pruning enabled for ppc64le we should be able to deal effectively with the /boot space issue without having to block on #1465. We have enabled ppc64le for testing and next in coreos/fedora-coreos-pipeline#876 and will produce official artifacts in the next round of releases.

@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-next-release Fixed upstream. Waiting on a next release. labels Jun 6, 2023
@dustymabe
Copy link
Member

The fix for this went into next stream release 38.20230609.1.0. Please try out the new release and report issues.

@dustymabe
Copy link
Member

The fix for this went into testing stream release 38.20230609.2.1. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-next-release Fixed upstream. Waiting on a next release. labels Jun 13, 2023
@dustymabe dustymabe changed the title produce official ppc64le artifacts Produce official ppc64le architecture artifacts Jun 13, 2023
dustymabe added a commit to dustymabe/fedora-coreos-pipeline that referenced this issue Jun 27, 2023
dustymabe added a commit to coreos/fedora-coreos-pipeline that referenced this issue Jun 27, 2023
Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-pipeline that referenced this issue Jul 6, 2023
@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Jul 13, 2023
@dustymabe
Copy link
Member

The fix for this went into stable stream release 38.20230625.3.0.

HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira kind/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants