only set LIBGUESTFS_HV for ppc64le on el7 #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dustymabe
commented
Aug 11, 2022
•
dustymabe
commented
dustymabe
force-pushed
the
dusty-ppc64le-p9
branch
from
952efa0
to
933ffcb
Compare
This setting of cmd.Env was overriding the LIBGUESTFS_BACKEND=direct that was being set just a few lines before. So the command was getting run with just LIBGUESTFS_HV being set, which happens to have no effect unless LIBGUESTFS_BACKEND=direct is set. Fix that by appending to cmd.Env on the second modification.
It appears the newer P9 hardware that we are utilizing that is running a Fedora stack doesn't need this. Local testing seems to work fine. Let's hack around this for now while we still have el7 clusters.
dustymabe
force-pushed
the
dusty-ppc64le-p9
branch
from
933ffcb
to
6c25ec0
Compare
cgwalters
approved these changes
Aug 16, 2022
| if err := unix.Uname(&u); err != nil { | ||
| return nil, errors.Wrapf(err, "detecting kernel information") | ||
| } | ||
| if strings.Contains(fmt.Sprintf("%s", u.Release), "el7") { |
There was a problem hiding this comment.
I think this would be slightly better as:
Suggested change
| if strings.Contains(fmt.Sprintf("%s", u.Release), "el7") { | |
| if strings.Contains(string(u.Release), "el7") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.