This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
ssh: define the list of Key Algorithms of remote hosts before handshake #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue | ||
| } | ||
| ipAddr, err := kc.addrToHostPort(remoteIP.String()) | ||
| if err != nil { |
Retrieve remote host Key Algorithms from known_host if they are there and use them to perform ssh handshake. Otherwise fallback to default values suggested by remote. This patch is based from a previous patch written by: kayrus <kay.diam@gmail.com> Resolves coreos#1526 and coreos/bugs#1186
tixxdz
force-pushed
the
tixxdz/ssh_known_hosts_fixes
branch
from
f3b1dc3
to
d81fe84
Compare
|
Without this patch: With the patch: LGTM |
|
@crawford @jonboulle @kayrus this seems to work and it is a high priority fix, If no one objects I'll merge it tonight. The code doesn't have side effects, on errors we return nil which the upstream ssh library will ignore and fallback to the old behaviour. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve remote host Key Algorithms from known_host if they are there
and use them to perform ssh handshake. Otherwise fallback to default
values suggested by remote.
This patch is based from a previous patch written by:
kayrus kay.diam@gmail.com
Resolves #1526 and coreos/bugs#1186