This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
engine: fix a bug in engine being unreachable #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/engine-fix-grpc-conn
branch
from
267f1aa
to
278949a
Compare
When gRPC turned on, TestScheduleMachineOf fails sometimes, as the engine becomes unreachable with the following error messages: ==== transport: http2Client. notifyError got notified that the client transport was broken EOF. ERROR registrymux.go:166: Retry to connect to new engine: dial tcp 172.18.1.1:50059: getsockopt: connection refused ERROR registrymux.go:166: Retry to connect to new engine: dial tcp 172.18.1.1:50059: getsockopt: connection refused ERROR registrymux.go:166: Retry to connect to new engine: dial tcp 172.18.1.1:50059: getsockopt: connection refused ==== This must have been a regression from commit ecb121a ("registry/rpc: use simpleBalancer instead of ClientConn.State()"). Remove the additional checking with IsRegistryReady, in order to avoid the occasional case of engine being unreachable. Fixes coreos#1712
dongsupark
force-pushed
the
dongsu/engine-fix-grpc-conn
branch
from
278949a
to
82dac98
Compare
|
Yep, it seems to really help. I'll merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gRPC is turned on,
TestScheduleMachineOffails sometimes, as the engine becomes unreachable with the following error messages:This must have been a regression from commit ecb121a ("registry/rpc: use simpleBalancer instead of ClientConn.State()"). Remove the additional checking with IsRegistryReady, in order to avoid the occasional case of engine being unreachable.
Fixes #1712