This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Make fleetctl stop/unload more helpful #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The multi-state transition should really just be handled by the engine, but it isn't quite smart enough yet to handle that much work. For now, we'll just help the user do it in fleetctl. |
| @@ -16,6 +18,11 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| func init() { | |||
| cmdUnloadUnit.Flags.IntVar(&sharedFlags.BlockAttempts, "block-attempts", 10, "Wait until the jobs are loaded, performing up to N attempts before giving up.") | |||
There was a problem hiding this comment.
Didn't even read these comments...
|
Yeah, this is definitely pretty awkward having all this in the client. |
|
@jonboulle I'd like to get this implemented here so we can get some functional tests written against the overall behavior, then refactor it out into the engine. |
|
👍 for now, and I for one look forward to our new engine overlords. |
Like load and start, unload and stop should block on success. Additionally, unload should attempt to stop a job before fully unloading it.
bcwaldon
added a commit
that referenced
this pull request
Apr 18, 2014
Make fleetctl stop/unload more helpful
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like load and start, unload and stop should block on success. Additionally, unload should attempt to stop a job before fully unloading it.